> -----Original Message----- > From: Dexuan Cui > Sent: Tuesday, March 6, 2018 10:22 AM > To: [email protected]; [email protected]; KY Srinivasan > <[email protected]>; > Stephen Hemminger <[email protected]>; [email protected]; > [email protected]; > [email protected] > Cc: [email protected]; [email protected]; > Haiyang Zhang > <[email protected]>; [email protected]; [email protected]; > Michael > Kelley (EOSG) <[email protected]>; Dexuan Cui > <[email protected]>; Jack > Morgenstein <[email protected]>; [email protected] > Subject: [PATCH v3 2/6] PCI: hv: hv_eject_device_work(): remove the bogus test > > When we're in the function, hpdev->state must be hv_pcichild_ejecting: > see hv_pci_eject_device(). > > Signed-off-by: Dexuan Cui <[email protected]> > Cc: Vitaly Kuznetsov <[email protected]> > Cc: Jack Morgenstein <[email protected]> > Cc: [email protected] > Cc: Stephen Hemminger <[email protected]> > Cc: K. Y. Srinivasan <[email protected]> > Cc: Michael Kelley (EOSG) <[email protected]> > --- > drivers/pci/host/pci-hyperv.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c > index 1233300f41c6..04edb24c92ee 100644 > --- a/drivers/pci/host/pci-hyperv.c > +++ b/drivers/pci/host/pci-hyperv.c > @@ -1796,10 +1796,7 @@ static void hv_eject_device_work(struct work_struct > *work) > > hpdev = container_of(work, struct hv_pci_dev, wrk); > > - if (hpdev->state != hv_pcichild_ejecting) { > - put_pcichild(hpdev, hv_pcidev_ref_pnp); > - return; > - } > + WARN_ON(hpdev->state != hv_pcichild_ejecting); > > /* > * Ejection can come before or after the PCI bus has been set up, so > -- > 2.7.4
Reviewed-by: Michael Kelley <[email protected]> _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
