On Fri, Jan 12, 2018 at 05:36:40AM -0700, Kenny Ballou wrote:
> Fix a number of checkpatch warnings in xgfib/vb_setmode.c about line
> length being over 80 characters.
>
> Signed-off-by: Kenny Ballou <[email protected]>
> ---
> drivers/staging/xgifb/vb_setmode.c | 78
> ++++++++++++++++++++++++++------------
> 1 file changed, 54 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c
> b/drivers/staging/xgifb/vb_setmode.c
> index e9d930f150cb..6856286c3b5a 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -74,7 +74,8 @@ static void XGI_SetSeqRegs(struct vb_device_info *pVBInfo)
> /* Get SR1,2,3,4 from file */
> /* SR1 is with screen off 0x20 */
> SRdata = XGI330_StandTable.SR[i];
> - xgifb_reg_set(pVBInfo->P3c4, i + 1, SRdata); /* Set SR 1 2 3 4
> */
> + /* Set SR 1 2 3 4 */
> + xgifb_reg_set(pVBInfo->P3c4, i + 1, SRdata);
> }
> }
>
> @@ -714,7 +715,9 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
> data &= 0x7F;
> xgifb_reg_set(pVBInfo->P3d4, 0x11, data); /* Unlock CRTC */
> xgifb_reg_set(pVBInfo->P3d4, 0x01, (unsigned short)(tempcx & 0xff));
> - xgifb_reg_and_or(pVBInfo->P3d4, 0x0b, ~0x0c,
> + xgifb_reg_and_or(pVBInfo->P3d4,
> + 0x0b,
> + ~0x0c,
Huh? What's this?
> (unsigned short)((tempcx & 0x0ff00) >> 10));
> xgifb_reg_set(pVBInfo->P3d4, 0x12, (unsigned short)(tempbx & 0xff));
> tempax = 0;
> @@ -1225,9 +1228,10 @@ static void const *XGI_GetLcdPtr(struct
> XGI330_LCDDataTablStruct const *table,
> return table[i].DATAPTR;
> }
>
> -static struct SiS_TVData const *XGI_GetTVPtr(unsigned short ModeIdIndex,
> - unsigned short
> RefreshRateTableIndex,
> - struct vb_device_info *pVBInfo)
> +static struct SiS_TVData const *XGI_GetTVPtr(
> + unsigned short ModeIdIndex,
> + unsigned short RefreshRateTableIndex,
> + struct vb_device_info *pVBInfo)
The original was basically fine. I don't really like these indented one
tab because then it aligns with the code instead of the function
parameters.
> {
> unsigned short i, tempdx, tempal, modeflag;
>
> @@ -1468,7 +1472,8 @@ static void XGI_SetLVDSRegs(unsigned short ModeIdIndex,
> tempax |= tempcx;
>
> xgifb_reg_set(pVBInfo->Part1Port, 0x15, tempax);
> - xgifb_reg_set(pVBInfo->Part1Port, 0x14,
> + xgifb_reg_set(pVBInfo->Part1Port,
> + 0x14,
> (unsigned short)(tempbx & 0xff));
>
> tempax = pVBInfo->VT;
I just don't understand why you're doing this...
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
