This patch fixes this checkpatch.pl errors:
ERROR: space prohibited after that open parenthesis '('
+ if ( IS_ERR(device->gpiod[i]) )
ERROR: space prohibited before that close parenthesis ')'
+ if ( IS_ERR(device->gpiod[i]) )
ERROR: space prohibited before that close parenthesis
')' + (size - position) );
ERROR: space prohibited before that close parenthesis
')' + kthread_should_stop() );
ERROR: space prohibited after that open parenthesis '('
+ if ( retval != sizeof(instance->tx_cfg) )
ERROR: space prohibited before that close parenthesis ')'
+ if ( retval != sizeof(instance->tx_cfg) )
Signed-off-by: Oliver Graute <[email protected]>
---
drivers/staging/pi433/pi433_if.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 19c6270..bafe2cc 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -742,7 +742,7 @@ static irqreturn_t DIO1_irq_handler(int irq, void *dev_id)
repetitions--;
rf69_write_fifo(spi,
&buffer[position],
- (size - position) );
+ (size - position));
position = 0; /* reset for next repetition */
}
@@ -755,7 +755,7 @@ static irqreturn_t DIO1_irq_handler(int irq, void *dev_id)
dev_dbg(device->dev, "thread: wait for packet to get sent/fifo
to be empty");
wait_event_interruptible(device->fifo_wait_queue,
device->free_in_fifo == FIFO_SIZE ||
- kthread_should_stop() );
+ kthread_should_stop());
if ( kthread_should_stop() ) printk("ABORT\n");
@@ -853,7 +853,7 @@ static irqreturn_t DIO1_irq_handler(int irq, void *dev_id)
goto abort;
retval = kfifo_in (&device->tx_fifo, &count, sizeof(size_t));
- if ( retval != sizeof(size_t) )
+ if (retval != sizeof(size_t))
goto abort;
retval = kfifo_from_user(&device->tx_fifo, buf, count, &copied);
@@ -1081,10 +1081,9 @@ static void free_GPIOs(struct pi433_device *device)
{
int i;
- for (i = 0; i < NUM_DIO; i++)
- {
+ for (i = 0; i < NUM_DIO; i++) {
/* check if gpiod is valid */
- if ( IS_ERR(device->gpiod[i]) )
+ if (IS_ERR(device->gpiod[i]))
continue;
free_irq(device->irq_num[i], device);
--
1.9.1
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
