On Wed, Nov 29, 2017 at 10:32:00PM +0900, Tetsuo Handa wrote: > register_shrinker() might return -ENOMEM error since Linux 3.12. > > Signed-off-by: Tetsuo Handa <[email protected]> > Cc: Robert Love <[email protected]> > Cc: Marco Nelissen <[email protected]> > Cc: John Stultz <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Michal Hocko <[email protected]> > --- > drivers/staging/android/ashmem.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c > b/drivers/staging/android/ashmem.c > index 0f695df..ab56f81 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -862,12 +862,18 @@ static int __init ashmem_init(void) > goto out_free2; > } > > - register_shrinker(&ashmem_shrinker); > + ret = register_shrinker(&ashmem_shrinker); > + if (unlikely(ret)) {
Never use unlikely/likely unless you can benchmark the speed change. Hint, in init functions you never need this... Please fix up and resend. thanks, greg k-h _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
