> -----Original Message----- > From: Andrew Lunn [mailto:[email protected]] > Sent: Monday, October 02, 2017 18:37 > To: Razvan Stefanescu <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; [email protected]; [email protected]; > [email protected]; Alexandru Marginean <[email protected]>; > Bogdan Purcareata <[email protected]>; Ruxandra Ioana Radulescu > <[email protected]>; Laurentiu Tudor <[email protected]>; > [email protected] > Subject: Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support > > Hi Razvan > > > +static void ethsw_get_drvinfo(struct net_device *netdev, > > + struct ethtool_drvinfo *drvinfo) > > +{ > > + struct ethsw_port_priv *port_priv = netdev_priv(netdev); > > + u16 version_major, version_minor; > > + int err; > > + > > + strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver)); > > + strlcpy(drvinfo->version, ethsw_drv_version, sizeof(drvinfo->version)); > > Software driver versions are mostly useless. I would suggest you > remove this. > > Andrew Thank you. I'll remove it in v3.
Best regards, Razvan S. _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
