On Tue, 30 May 2017 19:17:46 +0000
Jork Loeser <[email protected]> wrote:

> > -----Original Message-----
> > From: Andy Shevchenko [mailto:[email protected]]
> > Sent: Tuesday, May 30, 2017 09:53
> > To: Vitaly Kuznetsov <[email protected]>
> > Cc: [email protected]; [email protected]; linux-
> > [email protected]; KY Srinivasan <[email protected]>; Haiyang Zhang
> > <[email protected]>; Stephen Hemminger <[email protected]>;
> > Thomas Gleixner <[email protected]>; Ingo Molnar <[email protected]>; H.
> > Peter Anvin <[email protected]>; Steven Rostedt <[email protected]>; Jork
> > Loeser <[email protected]>; Simon Xiao <[email protected]>;
> > Andy Lutomirski <[email protected]>
> > Subject: Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB 
> > flush
> > 
> > On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov <[email protected]>
> > wrote:  
> > > +#define HV_FLUSH_ALL_PROCESSORS                        0x00000001
> > > +#define HV_FLUSH_ALL_VIRTUAL_ADDRESS_SPACES    0x00000002
> > > +#define HV_FLUSH_NON_GLOBAL_MAPPINGS_ONLY      0x00000004
> > > +#define HV_FLUSH_USE_EXTENDED_RANGE_FORMAT     0x00000008  
> > 
> > BIT() ?  
> 
> Certainly a matter of taste. Given that the Hyper-V spec lists these as hex 
> numbers, I find the explicit numbers appropriate.
> 
> Regards,
> Jork

Keep the hex numbers, it makes more sense not to change it since rest of 
arch/x86/hyperv
uses hex values.
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to