> New helpers take pointers to uuid_{be|le} as parameters.
>
> When using them on a raw data we don't need to do an ugly dereference and,
> in some cases, a type casting.
>
> Cc: Andrew Morton <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Liam Girdwood <[email protected]>
> Cc: Mark Brown <[email protected]>
> Cc: Vinod Koul <[email protected]>
> Cc: Srinivas Pandruvada <[email protected]>
> Cc: Benjamin Tissoires <[email protected]>
> Cc: Kirti Wankhede <[email protected]>
> Cc: Alex Williamson <[email protected]>
> Cc: "K. Y. Srinivasan" <[email protected]>
> Cc: Haiyang Zhang <[email protected]>
> Cc: Stephen Hemminger <[email protected]>
> Cc: Tomas Winkler <[email protected]>
> Cc: Matt Fleming <[email protected]>
> Cc: Ard Biesheuvel <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> include/linux/uuid.h | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/include/linux/uuid.h b/include/linux/uuid.h index
> 4dff73a89758..45312cb5ac65 100644
> --- a/include/linux/uuid.h
> +++ b/include/linux/uuid.h
> @@ -58,6 +58,26 @@ static inline int uuid_be_cmp(const uuid_be u1, const
> uuid_be u2)
> return memcmp(&u1, &u2, sizeof(uuid_be)); }
>
> +static inline int uuid_le_cmp_p(const uuid_le *pu1, const uuid_le u2) {
> + return memcmp(pu1, &u2, sizeof(uuid_le)); }
> +
> +static inline int uuid_be_cmp_p(const uuid_be *pu1, const uuid_be u2) {
> + return memcmp(pu1, &u2, sizeof(uuid_be)); }
> +
> +static inline int uuid_le_cmp_pp(const uuid_le *pu1, const uuid_le
> +*pu2) {
> + return memcmp(pu1, pu2, sizeof(uuid_le)); }
> +
> +static inline int uuid_be_cmp_pp(const uuid_be *pu1, const uuid_be
> +*pu2) {
> + return memcmp(pu1, pu2, sizeof(uuid_be)); }
> +
> void generate_random_uuid(unsigned char uuid[16]);
>
> extern void uuid_le_gen(uuid_le *u);
There's a bug in gcc wherein constant compound literals are generated
on the stack at runtime, rather than stored in rodata. The bug occurs
if the compound literal is passed by reference. It does not manifest
itself when passing by value:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68725
Hence this patch is unfortunately counterproductive if the UUIDs are
declared const.
FWIW I've posted a series back in January to constify UUIDs as much as
possible, but I got some objections and lacked the time so far to
address them. In fact I'm thinking that gcc needs to be fixed first,
then we can focus on improving the kernel side of things:
https://www.spinics.net/lists/linux-efi/msg10093.html
Best regards,
Lukas
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
