From: David Binder <[email protected]> The 'retry' variable created in handle_command() is statically allocated, and its address is never set to NULL. Therefore conditionals to verify the validity of the retry variable's address are unnecessary.
Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Binder <[email protected]> Signed-off-by: David Kershner <[email protected]> --- drivers/staging/unisys/visorbus/visorchipset.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index 275653a..b6f1ccf 100644 --- a/drivers/staging/unisys/visorbus/visorchipset.c +++ b/drivers/staging/unisys/visorbus/visorchipset.c @@ -1852,8 +1852,7 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, bool *retry) int allocbytes = sizeof(struct parser_context) + bytes; struct parser_context *ctx; - if (retry) - *retry = false; + *retry = false; /* * alloc an 0 extra byte to ensure payload is @@ -1862,14 +1861,12 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, bool *retry) allocbytes++; if ((controlvm_payload_bytes_buffered + bytes) > MAX_CONTROLVM_PAYLOAD_BYTES) { - if (retry) - *retry = true; + *retry = true; return NULL; } ctx = kzalloc(allocbytes, GFP_KERNEL | __GFP_NORETRY); if (!ctx) { - if (retry) - *retry = true; + *retry = true; return NULL; } -- git-series 0.9.1 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
