Same stuff. Run checkpatch.pl.
> + gpio_set_value(par->gpio.dc, 1);
> + /* Write data */
> +
> + ret =
> + par->fbtftops.write(par, par->txbuf.buf,
> + par->info->var.xres * par->info->var.yres / 2);
Clean that line.
> +static struct fbtft_display display = {
> + .regwidth = 8,
> + .width = WIDTH,
> + .height = HEIGHT,
> + .txbuflen = WIDTH * HEIGHT / 2,
The other driver didn't have a txbuflen. What does that do? (I have
barely looked at fbtft before so I don't know).
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel