Re: [PATCH 29/38] staging: wilc1000: remove goto from linux_wlan_start_firmware

[Dan Carpenter]

On Mon, Nov 02, 2015 at 05:51:12PM +0900, Glen Lee wrote:
>       PRINT_D(INIT_DBG, "Waiting for Firmware to get ready ...\n");
>       ret = linux_wlan_lock_timeout(&wilc->sync_event, 5000);
>       if (ret) {
>               PRINT_D(INIT_DBG, "Firmware start timed out");
> -             goto _fail_;
> +             return ret;
>       }
>       PRINT_D(INIT_DBG, "Firmware successfully started\n");
>  
> -_fail_:
>       return ret;

In a later patch, could you change this from "return ret;" to
"return 0;"

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel