> -----Original Message----- > From: Greg KH [mailto:[email protected]] > Sent: Sunday, October 25, 2015 7:13 PM > To: Pan Lijun-B44306 <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; Yoder Stuart-B08248 <[email protected]>; > katz Itai-RM05202 <[email protected]>; Rivera Jose-B46482 > <[email protected]>; Li Yang-Leo-R58472 <[email protected]>; > Wood Scott-B07421 <[email protected]>; [email protected]; Hamciuc > Bogdan-BHAMCIU1 <[email protected]>; Marginean Alexandru-R89243 > <[email protected]>; Sharma Bhupesh-B45370 > <[email protected]>; Erez Nir-RM30794 > <[email protected]>; Schmitt Richard-B43082 > <[email protected]>; [email protected] > Subject: Re: [PATCH 2/5] staging: fsl-mc: define a macro to differentiate root > dprc > > On Sun, Oct 25, 2015 at 05:41:20PM -0500, Lijun Pan wrote: > > Define is_root_dprc(dev) to tell whether a device is root dprc or not > > via platform_bus_type. > > > > Signed-off-by: Lijun Pan <[email protected]> > > --- > > drivers/staging/fsl-mc/include/mc.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/staging/fsl-mc/include/mc.h > > b/drivers/staging/fsl-mc/include/mc.h > > index a933291..483763e 100644 > > --- a/drivers/staging/fsl-mc/include/mc.h > > +++ b/drivers/staging/fsl-mc/include/mc.h > > @@ -14,6 +14,7 @@ > > #include <linux/device.h> > > #include <linux/mod_devicetable.h> > > #include <linux/list.h> > > +#include <linux/platform_device.h> > > #include "../include/dprc.h" > > > > #define FSL_MC_VENDOR_FREESCALE 0x1957 > > @@ -109,6 +110,15 @@ struct fsl_mc_resource { > > #define FSL_MC_IS_DPRC 0x0001 > > > > /** > > + * root dprc's parent is a platform device > > + * that platform device's bus type is platform_bus_type. > > + */ > > +#define is_root_dprc(dev) \ > > + ((to_fsl_mc_device(dev)->flags & FSL_MC_IS_DPRC) && \ > > + ((dev)->bus == &fsl_mc_bus_type) && \ > > + ((dev)->parent->bus == &platform_bus_type)) > > + > > It's best to make this type of thing a static inline function, to ensure you > get the > correct typechecking. >
I will take your suggestion and make changes in patch v2. Lijun > thanks, > > greg k-h _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
