On Thursday 22 October 2015 15:16:39 Shraddha Barke wrote:
> On Thu, 22 Oct 2015, Arnd Bergmann wrote:
>
> > On Thursday 22 October 2015 14:50:18 Shraddha Barke wrote:
> >> These patches remove the definitions of functions which are not used.
> >>
> >> Shraddha Barke (2):
> >> Staging: lustre: ptlrpc: Remove unused functions
> >> Staging: lustre: obdclass: Remove unused functions
> >>
> >> .../lustre/lustre/obdclass/lprocfs_status.c | 139
> >> ---------------------
> >> .../staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 63 ----------
> >> 2 files changed, 202 deletions(-)
> >>
> >>
> >
> > How did you check that they are indeed unused? I suspect these two patches
> > are wrong.
>
> I grepped for the uses of these functions. When I did make
> M=drivers/staging/lustre, I didn't get errors. What am I missing here?
I see now that you did not remove the declarations from the header files.
Please remove those and try again. Alternatively, you should see link-time
errors when you try to do 'make' without the listing directory.
Arnd
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
