On Tue, 2015-09-08 at 21:53 +0530, Sudip Mukherjee wrote:
> The member qc_idx of struct if_quotactl is unsigned and hence it can
> never be less than zero.
[]
> diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c
> b/drivers/staging/lustre/lustre/lov/lov_obd.c
[]
> @@ -1487,7 +1487,7 @@ static int lov_iocontrol(unsigned int cmd, struct
> obd_export *exp, int len,
> struct obd_quotactl *oqctl;
>
> if (qctl->qc_valid == QC_OSTIDX) {
> - if (qctl->qc_idx < 0 || count <= qctl->qc_idx)
> + if (count <= qctl->qc_idx)
Perhaps this test would be clearer reversed too
if (qctl->qc_idx >= count)
> return -EINVAL;
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
