On 15/08/15 01:31, H Hartley Sweeten wrote:
checkpatch.pl reports:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Change the error code to -ENOIOCTLCMD/
Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Ian Abbott <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
drivers/staging/comedi/drivers/serial2002.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/serial2002.c
b/drivers/staging/comedi/drivers/serial2002.c
index c6f9855..60d7d73 100644
--- a/drivers/staging/comedi/drivers/serial2002.c
+++ b/drivers/staging/comedi/drivers/serial2002.c
@@ -101,7 +101,7 @@ static long serial2002_tty_ioctl(struct file *f, unsigned
op,
if (f->f_op->unlocked_ioctl)
return f->f_op->unlocked_ioctl(f, op, param);
- return -ENOSYS;
+ return -ENOIOCTLCMD;
}
I think ENOIOCTLCMD means something like "try some other ioctl handler"
and should get converted to ENOTTY by the code higher up the return path
if there is no other ioctl handler. Still, it might be safer to return
-ENOTTY directly here. Not that it really matters, as the return value
from this function is currently ignored.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
