The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton <[email protected]> To: Larry Finger <[email protected]>, Florian Schilhabel <[email protected]>, Greg Kroah-Hartman <[email protected]>, Sudip Mukherjee <[email protected]>, Nitin Kuppelur <[email protected]>, Joshua Clayton <[email protected]>, Vaishali Thakkar <[email protected]>, Tapasweni Pathak <[email protected]>, Daniel Baluta <[email protected]>, Melike Yurtoglu <[email protected]>, Max Perepelitsyn <[email protected]>, Aya Mahfouz <[email protected]>, Cristina Opriceana <[email protected]>, Dogukan Ergun <[email protected]>, Julia Lawall <[email protected]>, Dan Carpenter <[email protected]>, Haneen Mohammed <[email protected]>, Rickard Strandqvist <[email protected]> Cc: [email protected], [email protected] Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompil...@gmail.com> X-Mailer: git-send-email 2.4.6 In-Reply-To: <[email protected]> References: <[email protected]> In-Reply-To: <[email protected]> References: <[email protected]> The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton <[email protected]> --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
