From: Dexuan Cui <[email protected]>
Date: Tue, 14 Jul 2015 03:00:48 -0700
> + pr_debug("hvsock_sk_destruct: called\n");
Debug logging just to state that a function is called is not appropriate,
we have very sophisticated tracing facilities in the kernel that can do
that transparently, and more.
PLease remove this.
> + if (hvsk->channel) {
> + pr_debug("hvsock_sk_destruct: calling vmbus_close()\n");
Likewise, these kinds of debug logs are totally inappropriate.
> +static int hvsock_release(struct socket *sock)
> +{
> + /* sock->sk is NULL, if accept() is interrupted by a signal */
> + if (sock->sk) {
> + __hvsock_release(sock->sk);
> + sock->sk = NULL;
> + }
> +
> + sock->state = SS_FREE;
> + pr_debug("hvsock_release called\n\n");
Likewise.
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
