> -----Original Message-----
> From: Greg KH [mailto:[email protected]]
> Sent: Monday, June 15, 2015 12:52 PM
> To: Jake Oshins
> Cc: KY Srinivasan; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; Haiyang Zhang; Mike Ebersol
> Subject: Re: [PATCH v2 4/6] drivers:hv: Export a function that maps Linux
> proc num onto Hyper-V proc num
> 
> > +/**
> > + * This function returns the mapping between the Linux processor
> > + * number and
> > + * the hypervisor's virtual processor number, useful in making
> > + * hypercalls and such that talk about specific processors.
> > + *
> > + * @param procnum - in Linux terms
> 
> What kind of comment structure is this?  It's not kernel doc :(
> 
> And "procnum" sounds like "process number", why not "cpu_number"?

Thanks.  I'll wait a little while to see if any other feedback comes in and 
then I'll fix these and resend.

-- Jake Oshins

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to