On Fri, Jun 12, 2015 at 07:21:11PM +0900, Dean Lee wrote:
> remove OS Wrapper function(wilc_oswrapper.h) is in our plan.
> i removed OS Wrapper function and it's done.
> and i found wilc_type.h file is does not used it.
> so i deleted them and modify #include line in another file.
You are also doing other things here that you don't describe:
> /* Errors will always get printed */
> -#define WILC_ERROR(...) do { WILC_PRINTF("(ERR)(%s:%d) ",
> __WILC_FUNCTION__, __WILC_LINE__); \
> - WILC_PRINTF(__VA_ARGS__); \
> - } while (0)
> +#define WILC_ERROR(...)
> \
> +do { \
> + WILC_PRINTF("(ERR)(%s:%d)", __WILC_FUNCTION__, __WILC_LINE__); \
> + WILC_PRINTF(__VA_ARGS__); \
> +} while (0)
You reformatted this.
> #if (WILC_LOG_VERBOSITY_LEVEL > 3)
> -#define WILC_FN_IN do { WILC_PRINTF("(FIN) (%s:%d) \n", __WILC_FUNCTION__,
> __WILC_LINE__); } while (0)
> -#define WILC_FN_OUT(ret) do { WILC_PRINTF("(FOUT) (%s:%d) %d.\n",
> __WILC_FUNCTION__, __WILC_LINE__, (ret)); } while (0)
> +#define WILC_FN_IN \
> + WILC_PRINTF("(FIN)(%s:%d)\n", __WILC_FUNCTION__, __WILC_LINE__)
> +#define WILC_FN_OUT(ret) \
> + WILC_PRINTF("(FOUT)(%s:%d)%d\n", __WILC_FUNCTION__, __WILC_LINE__, ret)
And changed this for no obvious reason.
Please, only do one thing per patch. Break this up into logical steps
and resend it as a series of patches, with the last one being the TODO
file item removal.
thanks,
greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
