drivers/staging/lustre/lustre/llite/dir.c:1440:3-8: WARNING: NULL check before 
freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or 
usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid 
passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Julia Lawall <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---

 dir.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -1436,8 +1436,7 @@ lmv_out_free:
                        goto free_lmv;
                }
 free_lmv:
-               if (tmp)
-                       kfree(tmp);
+               kfree(tmp);
                return rc;
        }
        case LL_IOC_REMOVE_ENTRY: {
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to