* K. Y. Srinivasan <[email protected]> wrote:
> If the hypervisor supports MSR based access to the APIC registers
> (EOI, TPR and ICR), implement the MSR based access.
>
> Signed-off-by: K. Y. Srinivasan <[email protected]>
> ---
> Changes from V1: Addressed comments from Ingo Molnar
> <[email protected]>
You didn't address my primary feedback:
> > So since we are trying to explain things, wouldn't this comment be
> > more informative if it explained why we are trying to use the
> > x2APIC facilities of Hyper-V?
> >
> > I.e. what are the benefits of using the x2apic API towards the
> > hypervisor?
please explain the purpose, context and benefits, not just what the
patch does - even if the comment from your first patch is now gone.
Thanks,
Ingo
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
