On 23/10/14 20:19, H Hartley Sweeten wrote:
Convert this driver to use comedi_load_firmware() to download the firmware
to the board.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Ian Abbott <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
  drivers/staging/comedi/drivers/me4000.c | 93 ++++++++++++++-------------------
  1 file changed, 40 insertions(+), 53 deletions(-)

It's fine as an adaptation of the currently disabled code, although the original firmware loading code could do with some improvement (sanity checking the firmware data length, and checking the BUSY bit more frequently to hopefully speed it the loading process).

Reviewed-by: Ian Abbott <[email protected]>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to