Re: [PATCH] Staging: rtl8712 removed unnecessary else after return

[Joe Perches]

On Wed, 2014-10-01 at 16:44 +0200, Nitin Kuppelur wrote:
> Removed unnecessary else after return to solve
> checkpatch.pl warning
[]
> diff --git a/drivers/staging/rtl8712/hal_init.c 
> b/drivers/staging/rtl8712/hal_init.c
[]
> @@ -389,10 +389,8 @@ uint rtl871x_hal_init(struct _adapter *padapter)
>       padapter->hw_init_completed = false;
>       if (padapter->halpriv.hal_bus_init == NULL)
>               return _FAIL;
> -     else {
> -             if (padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
> -                     return _FAIL;
> -     }
> +     if (padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
> +             return _FAIL;

Perhaps a more common style is to use:

        if (!padapter->halpriv.hal_bus_init ||
            padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
                return _FAIL;


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel