On 2014-09-04 00:58, Chase Southwood wrote:
git-grep reveals that hwdrv_apci1500.c is the only file in comedi that uses dev->hw_dev in calls to dev_{err,warn}(). The rest of the drivers pass dev->class_dev to these macros instead. Switch the dev_warn() calls in this driver to use dev->class_dev as well, for consistency.Signed-off-by: Chase Southwood <[email protected]> Cc: Ian Abbott <[email protected]> Cc: H Hartley Sweeten <[email protected]> --- As an aside, it looks like lots of these cases are actually error conditions that might be more appropriate use cases for dev_err(). But they could be changed in a follow on patch, this is enough for this one. .../comedi/drivers/addi-data/hwdrv_apci1500.c | 104 ++++++++++----------- 1 file changed, 52 insertions(+), 52 deletions(-)
Reviewed-by: Ian Abbott <[email protected]> -- -=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
