On Wed, Aug 06, 2014 at 02:29:45AM +0300, Dzonatans Melgalvis wrote:
> Fixing checkpatch warning - blank line missing after declaration.
>
> Signed-off-by: Dzonatans Melgalvis <[email protected]>
> ---
> drivers/staging/comedi/comedidev.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/staging/comedi/comedidev.h
> b/drivers/staging/comedi/comedidev.h
> index 58e58a3..c9b7978 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -57,6 +57,7 @@ struct comedi_subdevice {
> const unsigned int *maxdata_list; /* list is channel specific */
>
> const struct comedi_lrange *range_table;
> +
> const struct comedi_lrange *const *range_table_list;
Really? Why add that one? Shouldn't you just remove the previous line?
>
> unsigned int *chanlist; /* driver-owned chanlist (not used) */
> @@ -207,8 +208,10 @@ struct comedi_async {
> struct comedi_cmd cmd;
> wait_queue_head_t wait_head;
> unsigned int cb_mask;
> +
> int (*inttrig)(struct comedi_device *dev, struct comedi_subdevice *s,
> unsigned int x);
> +
> };
Why is that last line needed?
Please use your judgement with checkpatch fixes, this patch isn't ok
as-is, sorry.
greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
