Hi,
this is my patchset for the
drivers/staging/bcm/PHSModule.c
file. It contains cleanup patches for
* Replacing object->member->member constructs by variables
* Shortenings of long lines
* Whitespace cleanup
* Chaining of nested if statements (if (foo) if (bar) => if (foo && bar))
Note: As I do not have the appropriate hardware, I'm not able to test these
patches. I compiled them at least.
Kind regards,
Matthias Beyer
Matthias Beyer (22):
Staging: bcm: PHSModule.c: Whitespace & Indentation cleanup
Staging: bcm: PHSModule.c: Outsourced debug printing in own function
Staging: bcm: PHSModule.c: Outsourced debug printing for phs
classifier entry
Staging: bcm: PHSModule.c: Replaced member accessing with variable in
PhsDeletePHSRule()
Staging: bcm: PHSModule.c: Replaced nested if statements with logical
AND concatenation of the conditions
Staging: bcm: PHSModule.c: Reduced indentation level by using jump
label
Staging: bcm: PHSModule.c: Shortened lines
Staging: bcm: PHSModule.c: Reduced indentation by using jump label in
PhsDeleteSFRules()
Staging: bcm: PHSModule.c: Replaced member accessing with variables
Staging: bcm: PHSModule.c: Whitespace cleanup in PhsCompress()
Staging: bcm: PHSModule.c: Added missing braces around else block
Staging: bcm: PHSModule.c: Replaced member accessing with variable in
free_phs_service()
Staging: bcm: PHSModule.c: Replaced indentation level with goto jump
on bad condition
Staging: bcm: PHSModule.c: Rewrote ValidatePHSRuleComplete()
Staging: bcm: PHSModule.c: Added const keyword to
ValidatePHSRUleComplete() argument
Staging: bcm: PHSModule.c: Replaced member accessing with variable in
GetServiceFlowEntry()
Staging: bcm: PHSModule.c: Simplified nested if statements by linking
them with logical AND in GetServiceFlowEntry()
Staging: bcm: PHSModule.c: Simplified nested if statements by linking
them with logical AND in GetServiceFlowEntry()
Staging: bcm: PHSModule.c: Simplified nested if statements by linking
them with logical AND in GetPhsRuleEntry()
Staging: bcm: PHSModule.c: Replaced member accessing with variable in
CreateSFToClassifierRuleMapping()
Staging: bcm: PHSModule.c: Replaced if-else return code with simple
return assertion
Staging: bcm: PHSModule.c: Shortened lines
drivers/staging/bcm/PHSModule.c | 1098 ++++++++++++++++++++++++---------------
1 file changed, 676 insertions(+), 422 deletions(-)
--
2.0.1
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel