On Fri, 2014-06-13 at 22:48 -0400, Jeff Oczek wrote:
> Simple coding style changes
[]
> diff --git a/drivers/staging/tidspbridge/include/dspbridge/dblldefs.h
> b/drivers/staging/tidspbridge/include/dspbridge/dblldefs.h
[]
> @@ -168,11 +168,11 @@ struct dbll_attrs {
[]
> - s32(*fread) (void *, size_t, size_t, void *);
> - s32(*fseek) (void *, long, int);
> - s32(*ftell) (void *);
> - s32(*fclose) (void *);
> - void *(*fopen) (const char *, const char *);
> + s32 (*fread)(void *, size_t, size_t, void *);
> + s32 (*fseek)(void *, long, int);
> + s32 (*ftell)(void *);
> + s32 (*fclose)(void *);
> + void *(*fopen)(const char *, const char *);
> };
Better would be to describe the arguments with
variable names and align all the return values
void *(*fopen
s32 (*fread)(void *arg1, size_t val1, size_t val2, void *ptr1);
s32 (*fseek)(void *ptr1, long arg2, int arg3);
s32 (*ftell)(void * ptr);
s32 (*fclose)(void *ptr);
void *(*fopen)(const char *ptr1, const char *ptr2);
where arg, val, ptr are actually useful descriptors
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
