Hi Rob,
On Thu, Dec 10, 2020 at 2:47 PM Rob Herring <[email protected]> wrote:
>
> On Tue, Dec 08, 2020 at 08:55:22AM +0100, Sergio Paracuellos wrote:
> > The commit adds rt2880 compatible node in binding document.
> >
> > Signed-off-by: Sergio Paracuellos <[email protected]>
> > ---
> > .../pinctrl/ralink,rt2880-pinmux.yaml | 70 +++++++++++++++++++
> > 1 file changed, 70 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml
> > b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml
> > new file mode 100644
> > index 000000000000..7dea3e26d99e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pinctrl/ralink,rt2880-pinmux.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Ralink rt2880 pinmux controller
> > +
> > +maintainers:
> > + - Sergio Paracuellos <[email protected]>
> > +
> > +description:
> > + The rt2880 pinmux can only set the muxing of pin groups. muxing
> > indiviual pins
> > + is not supported. There is no pinconf support.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - ralink,rt2880-pinmux
>
> What's the control interface as you have no 'reg' property.
There is not used in pinctrl. Every pin has a gpio function and
pinctrl and gpio are separate drivers. Here only pin functions and
groups are defined. The glue
code for this driver is done in arch/mips/ralink/mt7621.c using
specific pinmux.h header defined for ralink and then all that settings
are used in drivers through
the pinctrl driver.
>
> > +
> > + pinctrl-0:
> > + description:
> > + A phandle to the node containing the subnodes containing default
> > + configurations. This is for pinctrl hogs.
> > +
> > + pinctrl-names:
> > + description:
> > + A pinctrl state named "default" can be defined.
> > + const: default
>
> These 2 properties go in consumer nodes.
Ok, So I have to remove them from here. I see.
>
> > +
> > +required:
> > + - compatible
> > +
> > +patternProperties:
> > + '[a-z0-9_-]+':
> > + if:
> > + type: object
> > + description: node for pinctrl.
> > + $ref: "pinmux-node.yaml"
> > + then:
>
> For new bindings, don't do this hack. Just name the nodes '-pins$'
I see. I will update bindings for pinctrl in staging and avoid this
if-then clause.
>
> > + properties:
> > + groups:
> > + description: Name of the pin group to use for the functions.
> > + enum: [i2c, spi, uart1, uart2, uart3, rgmii1, rgmii2, mdio,
> > + pcie, sdhci]
> > + function:
> > + description: The mux function to select
> > + enum: [gpio, i2c, spi, uart1, uart2, uart3, rgmii1, rgmii2,
> > + mdio, nand1, nand2, sdhci]
>
> additionalProperties: false
Ok, I will add this.
>
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + # Pinmux controller node
> > + - |
> > + pinctrl {
> > + compatible = "ralink,rt2880-pinmux";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&state_default>;
> > +
> > + state_default: pinctrl0 {
> > + };
> > +
> > + i2c_pins: i2c0 {
> > + i2c0 {
> > + groups = "i2c";
> > + function = "i2c";
> > + };
> > + };
> > + };
> > --
> > 2.25.1
> >
Thanks for the review.
Best regards,
Sergio Paracuellos
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
