Re: [PATCH 2/2 V2] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

[Dan Carpenter]

On Wed, Apr 16, 2014 at 02:49:34PM -0500, Larry Finger wrote:
>       if (auth_alg == 2) {
> +             /* get ether_type */
> +             ptr = ptr + pfhdr->attrib.hdrlen + LLC_HEADER_SIZE;
> +             memcpy(&ether_type, ptr, 2);
> +             ether_type = ntohs((unsigned short)ether_type);

The incorrect cast here introduces a new sparse warning.

https://lwn.net/Articles/205624/

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel