> -----Original Message----- > From: H. Peter Anvin [mailto:[email protected]] > Sent: Monday, April 14, 2014 10:02 AM > To: KY Srinivasan; [email protected]; [email protected]; linux- > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected] > Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic > appropriately > > On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote: > > This patch implements the proposal put forth by H. Peter Anvin > <[email protected]>. > > > > In version V1 of the patch, I had cleaned up the code based on comments > from Peter. > > In version V2 of the patch, I have addressed additional comments from > Peter. > > In this version of the patch, I have addressed Jan's comments > ([email protected]). > > > > Signed-off-by: K. Y. Srinivasan <[email protected]> > > Technically the patch looks good, but I'm going to have to reject it based on > the patch description. > > Keep in mind that the above description is the only thing that would go into > the git repository, and needs to be understandable to someone, say, > 10 years from now. > > The above says nothing about what the proposal was, and the motivation, > and the problems it addresses. So the patch is good, but please write a > proper, standalone description for it.
Thanks Peter; I will update the description and send it out soon. K. Y > > Thanks, > > -hpa > _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
