On Mon, 2014-03-17 at 08:20 +1300, Daniel Ngu wrote:
> Line over 80 characters
> Unchecked sscanf return value
[]
> diff --git a/drivers/staging/gdm724x/gdm_lte.c
> b/drivers/staging/gdm724x/gdm_lte.c
[]
> @@ -536,7 +567,8 @@ static u8 find_dev_index(u32 nic_type)
> return index;
> }
>
> -static void gdm_lte_netif_rx(struct net_device *dev, char *buf, int len, int
> flagged_nic_type)
> +static void gdm_lte_netif_rx(struct net_device *dev, char *buf, int len,
> + int flagged_nic_type)
> {
> u32 nic_type;
> struct nic *nic;
> @@ -551,28 +583,41 @@ static void gdm_lte_netif_rx(struct net_device *dev,
> char *buf, int len, int fla
[]
> struct dhcp_packet {
This one would be better fixed by moving the struct definition
out of this function altogether.
> u8 op; /* BOOTREQUEST or BOOTREPLY */
> - u8 htype; /* hardware address type. 1 = 10mb
> ethernet */
> + u8 htype; /* hardware address type.
> + 1 = 10mb ethernet */
> u8 hlen; /* hardware address length */
> u8 hops; /* used by relay agents only */
> u32 xid; /* unique id */
> - u16 secs; /* elapsed since client began
> acquisition/renewal */
> + u16 secs; /* elapsed since client began
> + acquisition/renewal */
> u16 flags; /* only one flag so far: */
> - #define BROADCAST_FLAG 0x8000 /* "I need
> broadcast replies" */
> - u32 ciaddr; /* client IP (if client is in
> BOUND, RENEW or REBINDING state) */
> + #define BROADCAST_FLAG 0x8000 /* "I need
> + broadcast
> + replies" */
> + u32 ciaddr; /* client IP (if client is in
> + BOUND, RENEW or REBINDING
> + state) */
> u32 yiaddr; /* 'your' (client) IP address */
> - /* IP address of next server to use in
> bootstrap, returned in DHCPOFFER, DHCPACK by server */
> + /* IP address of next server to use in
> + * bootstrap, returned in DHCPOFFER, DHCPACK by
> + * server */
> u32 siaddr_nip;
> u32 gateway_nip; /* relay agent IP address */
> - u8 chaddr[16]; /* link-layer client hardware
> address (MAC) */
> + u8 chaddr[16]; /* link-layer client hardware
> + address (MAC) */
> u8 sname[64]; /* server host name (ASCIZ) */
> u8 file[128]; /* boot file name (ASCIZ) */
> - u32 cookie; /* fixed first four option
> bytes (99,130,83,99 dec) */
> + u32 cookie; /* fixed first four option
> + bytes (99,130,83,99 dec) */
> } __packed;
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
