From: Fabio Estevam <[email protected]>

Fix the following static checker warnings:

drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() 
error: potential null dereference 'mode'.  (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_modes() 
error: potential null dereference 'mode'.  (drm_mode_create returns null)

Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Fabio Estevam <[email protected]>
---
Changes since v3:
- None
Changes since v2:
- None
Changes since v1:
- Fix typo in Subject

 drivers/staging/imx-drm/parallel-display.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/staging/imx-drm/parallel-display.c 
b/drivers/staging/imx-drm/parallel-display.c
index d610f07..08e47aa 100644
--- a/drivers/staging/imx-drm/parallel-display.c
+++ b/drivers/staging/imx-drm/parallel-display.c
@@ -61,6 +61,8 @@ static int imx_pd_connector_get_modes(struct drm_connector 
*connector)
 
        if (imxpd->mode_valid) {
                struct drm_display_mode *mode = drm_mode_create(connector->dev);
+               if (!mode)
+                       return -EINVAL;
                drm_mode_copy(mode, &imxpd->mode);
                mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
                drm_mode_probed_add(connector, mode);
@@ -69,6 +71,8 @@ static int imx_pd_connector_get_modes(struct drm_connector 
*connector)
 
        if (np) {
                struct drm_display_mode *mode = drm_mode_create(connector->dev);
+               if (!mode)
+                       return -EINVAL;
                of_get_drm_display_mode(np, &imxpd->mode, OF_USE_NATIVE_MODE);
                drm_mode_copy(mode, &imxpd->mode);
                mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
-- 
1.8.1.2

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to