On Mon, 2014-01-06 at 00:45 +0300, Dan Carpenter wrote:
> On Sun, Jan 05, 2014 at 04:17:36PM -0500, Dan LaManna wrote:
> > @@ -1358,22 +1358,22 @@ static inline int is_same_network(struct
> > ieee80211_network *src,
> > * We treat all <hidden> with the same BSSID and channel
> > * as one network
> > */
> > - return (((src->ssid_len == dst->ssid_len) || (ieee->iw_mode ==
> > IW_MODE_INFRA)) && /* YJ,mod, 080819,for hidden ap */
> > + return ((src->ssid_len == dst->ssid_len) || (ieee->iw_mode ==
> > IW_MODE_INFRA)) && /* YJ,mod, 080819,for hidden ap */
> > (src->channel == dst->channel) &&
> > !memcmp(src->bssid, dst->bssid, ETH_ALEN) &&
> > (!memcmp(src->ssid, dst->ssid, src->ssid_len) ||
> > (ieee->iw_mode == IW_MODE_INFRA)) && /* YJ,mod, 080819,for hidden ap */
> > ((src->capability & WLAN_CAPABILITY_IBSS) ==
> > (dst->capability & WLAN_CAPABILITY_IBSS)) &&
> > ((src->capability & WLAN_CAPABILITY_BSS) ==
> > - (dst->capability & WLAN_CAPABILITY_BSS)));
> > + (dst->capability & WLAN_CAPABILITY_BSS));
> > }
> >
>
> Break this up.
[]
> if (src->capability & WLAN_CAPABILITY_IBSS !=
> dst->capability & WLAN_CAPABILITY_IBSS)
Needs parentheses
if ((src->capability & WLAN_CAPABILITY_IBSS) !=
(dst->capability & WLAN_CAPABILITY_IBSS))
> return 0;
> if (src->capability & WLAN_CAPABILITY_BSS !=
> dst->capability & WLAN_CAPABILITY_BSS)
> return 0;
here too.
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
