On 2013/12/25 18:54, Sergei Shtylyov wrote: > Hello. > > On 25-12-2013 7:28, Ding Tianhong wrote: > >> Use possibly more efficient ether_addr_equal >> instead of memcmp. > >> Cc: Rupesh Gujare <[email protected]> >> Cc: Greg Kroah-Hartman <[email protected]> >> Cc: [email protected] >> Cc: [email protected] >> Signed-off-by: Tan Xiaojun <[email protected]> >> Signed-off-by: Ding Tianhong <[email protected]> >> --- >> drivers/staging/ozwpan/ozcdev.c | 2 +- >> drivers/staging/ozwpan/ozproto.c | 5 +++-- >> 2 files changed, 4 insertions(+), 3 deletions(-) > >> diff --git a/drivers/staging/ozwpan/ozcdev.c >> b/drivers/staging/ozwpan/ozcdev.c >> index 6ce0af9..c363f66 100644 >> --- a/drivers/staging/ozwpan/ozcdev.c >> +++ b/drivers/staging/ozwpan/ozcdev.c >> @@ -448,7 +448,7 @@ int oz_cdev_start(struct oz_pd *pd, int resume) >> } >> spin_lock(&g_cdev.lock); >> if ((g_cdev.active_pd == NULL) && >> - (memcmp(pd->mac_addr, g_cdev.active_addr, ETH_ALEN) == 0)) { >> + (ether_addr_equal(pd->mac_addr, g_cdev.active_addr))) { > > There's no point in enclosing function call into parens. > > WBR, Sergei >
ok, thanks. Regards Ding > > _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
