On Mon, 4 Nov 2013 02:11:50 +0300 Dan Carpenter <[email protected]> wrote:
> On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: > > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: > > > The icount.reserved[] array isn't initialized so it leaks stack > > > information to userspace. > > > > > > Reported-by: Nico Golde <[email protected]> > > > Reported-by: Fabian Yamaguchi <[email protected]> > > > Signed-off-by: Dan Carpenter <[email protected]> > > > > Reviewed-by: Josh Triplett <[email protected]> > > > > Also, you don't quite have the patch format right here; you should have > > a --- line after the commit mesage, followed by a diffstat. Did you use > > git format-patch to generate this patch? > > I normally don't include the diffstat. Which tools care about that? > As Josh already replied, it is most helpful for the human reviewer. Linus uses it all the time to see how intrusive a patch may be. Yes, please always include a diffstat for any patch you send. Thanks, -- Steve _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
