On Tue, Oct 29, 2013 at 10:06:34PM -0700, Lisa Nguyen wrote:
> --- a/drivers/staging/bcm/Bcmchar.c
> +++ b/drivers/staging/bcm/Bcmchar.c
> @@ -287,9 +287,9 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd,
> ULONG arg)
> struct bcm_rdm_buffer sRdmBuffer = {0};
> PCHAR temp_buff = NULL;
> UINT uiTempVar = 0;
> - if ((Adapter->IdleMode == TRUE) ||
> - (Adapter->bShutStatus == TRUE) ||
> - (Adapter->bPreparingForLowPowerMode == TRUE)) {
> + if ((Adapter->IdleMode == true) ||
> + (Adapter->bShutStatus == true) ||
> + (Adapter->bPreparingForLowPowerMode == true)) {
Your patch is fine but these variable names suck. How is "Mode" or
"Status" true or false? It should be something like:
if (adapter->idle || adapter->shutdown ||
addapter->preparing_for_low_power) {
(I assume that's what the code is trying to say).
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
