On Wed, Aug 21, 2013 at 09:48:38PM -0400, Lidza Louina wrote:
> -static int dgap_tty_ioctl(struct tty_struct *tty, struct file *file,
> unsigned int cmd,
> +static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
> unsigned long arg)
Btw, now that this file compiles I see it in my static checker runs.
dgap_tty_ioctl() takes a lock but always returns before unlocking.
> {
> struct board_t *bd;
> @@ -3423,41 +3423,6 @@ static int dgap_tty_ioctl(struct tty_struct *tty,
> struct file *file, unsigned in
>
> return(-ENOIOCTLCMD);
In other words, these return statements should be breaks so we hit
the call to:
DGNC_UNLOCK(ch->ch_lock, lock_flags);
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
