On Sat, Feb 20, 2010 at 12:22 PM, Maarten Maathuis <[email protected]> wrote:
> - Without this change I get a general protection fault.
> - Also use PTR_ERR where applicable.
I just want to make sure I understand, but really the only bit of this
patch that matters is:
> @@ -556,9 +559,10 @@ int ttm_tt_swapout(struct ttm_tt *ttm, struct file
> *persistant_swap_storage)
> if (unlikely(from_page == NULL))
> continue;
> to_page = read_mapping_page(swap_space, i, NULL);
> - if (unlikely(to_page == NULL))
> + if (unlikely(IS_ERR(to_page))) {
^^ these two lines where we are testing for NULL but should be
checking for an error?
> + ret = PTR_ERR(to_page);
> goto out_err;
> -
> + }
If that is true and the rest is just nice cleanups then I'm okay with it,.
Reviewed-by: Dave Airlie <[email protected]>
I'll need Thomas's ack on this also.
Dave.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
