W dniu 21 lutego 2010 00:04 użytkownik Rafał Miłecki <[email protected]> napisał: > W dniu 18 lutego 2010 19:08 użytkownik Jaime Velasco Juan > <[email protected]> napisał: >> El mié. 17 de feb. de 2010, a las 20:23:28 +0100, Rafał Miłecki escribió: >>> Signed-off-by: Rafał Miłecki <[email protected]> >>> Reported-by: Jaime Velasco Juan <[email protected]> >>> --- >>> This should make the trick, Jaime can you check if this works for you? Does >>> it >>> kill your corruptions? >> >> It doesn't work, it have the same problem than the current code: >> >> [ 8.682478] [drm] Requested: e: 68000 m: 80000 p: 16 >> [ 8.880126] [drm] Setting: e: 68000 m: 80000 p: 16 >> [ 9.280080] [drm] Requested: e: 30000 m: 40500 p: 16 >> [ 9.480118] [drm] Setting: e: 30000 m: 40500 p: 16 >> >> What about the attached version, does it seem ok to you?. It seems to fix >> the corruptions for me. > > Huh, your patch seems to do the same as my one. It just skips one > condition that should not matter.
Ahh, OK... I analyzed __wait_event_interruptible_timeout once again. This macro uses schedule_timeout but it loops until timer expires. So even if we wake_up it on VBLANK, but this happen before RADEON_WAIT_VBLANK_TIMEOUT, it will schedule_timeout again. That explains why your patch did work fine. Let me ask on LKML about introducing potential macro for us. -- Rafał ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
