On Fri, Sep 11, 2009 at 11:58:01AM +1000, Dave Airlie wrote: > > > > These patches break both free drivers out there. They not only break the > > API, they also require some of these ioctls to be used correctly for > > correct initialisation. There seems to be no attempt at working with > > these two drivers to fix this specific issue. > > I'm looking for the API break but not really seeing it, I can see > additions to the API. > > So it would be good if you could take a minute and write some inline > comments in a reply > to the patch, so we can track it. > > The only one I'd worry about is the extending of drm_via_init_t with > two new parameters. > > Granted if these ioctls are to be used by *chrome to workaround this > bug as well, then > it would be good if patches to those driver were made available so as > to get correct > operation. > > Otherwise these patches fail for the usual reasons, they actively > revert a change made upstream > (removing linux/types.h and reverting all that), also this should be > one patch, we don't need .c and .h > separate all the time, its also impossible to bisect across that sort of > thing. > > Dave.
As a first answer, without going in depth, as i just returned from my thursday constitutional. Do you have an explanation as to why this commit never made it to the kernel? > > No version was bumped, because i believe these are against the kernel > > copy of the drm, because for some reason the kernel copy never saw > > commit 659e9a091d3. And why did you suddenly start to care, while you pretty much ignored this dead before? Would that be for technical reasons? Luc Verhaegen. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
