On Sat, Aug 15, 2009 at 3:45 AM, Jesse Barnes<[email protected]> wrote: > On Fri, 14 Aug 2009 10:38:31 -0700 > Anssi Hannula <[email protected]> wrote: > >> Currently detailed timings are ignored on EDID < 1.3 with the comment >> "EDID up to and including 1.2 may put monitor info here". However, the >> EDID Implementation Guide only says that on EDID 1.1 (which introduced >> monitor descriptors) and EDID 1.2, the first descriptor block of the >> detailed timing section may also contain a monitor descriptor, while >> on later EDID revisions monitor descriptors are only allowed on the >> other blocks (2-4). >> >> Allow EDID < 1.2 to specify detailed timings by removing the check. >> The monitor descriptors on the first block will be correctly handled >> by the same code that handles monitor descriptors on blocks 2-4. >> >> X.org server, parse-edid and monitor-edid tools correctly do not >> ignore detailed timings in this case. >> >> Tested on Acer Aspire 7520 with GeForce 7000M and 17" 1440x900 LCD. >> >> Signed-off-by: Anssi Hannula <[email protected]> >> >> --- >> drm_edid.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> index 80cc6d0..9acdedf 100644 >> --- a/drivers/gpu/drm/drm_edid.c >> +++ b/drivers/gpu/drm/drm_edid.c >> @@ -502,10 +502,6 @@ static int add_detailed_info(struct >> drm_connector *connector, struct detailed_non_pixel *data = >> &timing->data.other_data; struct drm_display_mode *newmode; >> >> - /* EDID up to and including 1.2 may put monitor info >> here */ >> - if (edid->version == 1 && edid->revision < 3) >> - continue; >> - >> /* Detailed mode timing */ >> if (timing->pixel_clock) { >> newmode = drm_mode_detailed(dev, edid, >> timing, quirks); > > Yeah I've sent this before too, but I think it got missed. Dave can > you make sure something like this gets applied (if it hasn't been > already, I didn't check current sources)? >
the previous patch was to the edid revision in edid_is_valid, I don't remember seeing one to the detailed mode timings. I'll compare to the X server. Dave. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
