http://bugs.freedesktop.org/show_bug.cgi?id=21864





--- Comment #2 from Mathias Fröhlich <[email protected]>  2009-05-22 
04:56:43 PST ---
(In reply to comment #1)
> See commit e101959b6a262ba34a12b407ea6f480e6b4d7d72 for how I fixed this in
> master. Looks like that wasn't properly merge into radeon-rewrite.

Hmm, the R300_MAX_TEXTURE_SIZE define did not make it into the rewrite branch.
Indeed. The files in question are drastically changed.

I tried to define R300_MAX_TEXTURE_SIZE and use that like you did.
The problem here is that the radeon_mipmap_tree.h header where this static
array size is used is a radeon/r200/r300... data structure. So using a define
that is defined in R300 specific headers will not work.

Solutions:
* Define a mesa private define for the r* drivers.
* Or use a runtime dynamic sized array for that. For the rewrite branch it
would be possible to use the 'array at end of struct' trick and statically
declare a one sized array but CALLOC sufficient space for a
glCtx->MaxTextureLevels sized array. This way the second malloc could be
avoided - if this is your concern.

BTW. tell me if I am just too impatient. I hope that I can help to push that
corners where I can see problems. But if that is too early, tell me ...
Willing to provide patches when helpful.

Greetings and Thanks

Mathias


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to