On Fri, 2009-03-06 at 15:19 -0800, Eric Anholt wrote:

> Given that these functions aren't actually hooked up to anything, I'm
> not sure if there's any value here.  It sounds like we're going to go to
> using the resume_force_mode function for suspend/resume, which means
> we'd never use these.

I'm concerned that our mode setting code doesn't hit all of the same
registers that the suspend/resume code does. There are a pile of
registers which the BIOS may whack, and which will not be reset
correctly unless we save their values before the system is suspended the
first time.

Otherwise, I love the 'just set the mode' plan. Any chance we can strip
the suspend/resume code down to registers which our mode setting code
*doesn't* save/restore? Or merge suitable 'restorish' bits into the mode
setting path so that the other registers are set in the normal mode
setting path?

-- 
[email protected]

Attachment: signature.asc
Description: This is a digitally signed message part

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to