> > static void
> > +dri_gem_bo_reference_locked(dri_bo *bo)
> > +{
> > + drm_intel_bo_gem *bo_gem = (drm_intel_bo_gem *)bo;
> > +
> > + bo_gem->refcount++;
> > +}
> > +
> > +static void
> > drm_intel_gem_bo_reference_locked(drm_intel_bo *bo)
> > {
> > drm_intel_bo_gem *bo_gem = (drm_intel_bo_gem *)bo;
>
> This hunk looks like a dupe of the function below it.
Oops fixed. I don't think dri_gem_bo_reference_locked was even called...
>
> > diff --git a/libdrm/xf86drmMode.c b/libdrm/xf86drmMode.c
> > new file mode 100644
> > index 0000000..a0a164d
> > --- /dev/null
> > +++ b/libdrm/xf86drmMode.c
> > @@ -0,0 +1,684 @@
> > +/*
> > + * \file xf86drmMode.c
> > + * Header for DRM modesetting interface.
> > + *
> > + * \author Jakob Bornecrantz <[email protected]>
> > + *
> > + * \par Acknowledgements:
> > + * Feb 2007, Dave Airlie <[email protected]>
> > + */
> > +
> > +/*
> > + * Copyright (c) <year> <copyright holders>
>
> Copyright lols
Fixed. Jakob, Tungsten and Dave hold the copyrights here afaik.
> > + if (res.count_fbs)
> > + res.fb_id_ptr =
> > VOID2U64(drmMalloc(res.count_fbs*sizeof(uint32_t)));
> > + if (res.count_crtcs)
> > + res.crtc_id_ptr =
> > VOID2U64(drmMalloc(res.count_crtcs*sizeof(uint32_t))); + if
> > (res.count_connectors)
> > + res.connector_id_ptr =
> > VOID2U64(drmMalloc(res.count_connectors*sizeof(uint32_t)));
> > + if (res.count_encoders)
> > + res.encoder_id_ptr =
> > VOID2U64(drmMalloc(res.count_encoders*sizeof(uint32_t)));
> > +
> > + if (ioctl(fd, DRM_IOCTL_MODE_GETRESOURCES, &res)) {
> > + r = NULL;
> > + goto err_allocs;
> > + }
>
> The X Server's going to hate you for using ioctl instead of drmIoctl
> (not catching EINTR) all over here.
Good call, fixed.
>
> > diff --git a/libdrm/xf86drmMode.h b/libdrm/xf86drmMode.h
> > new file mode 100644
> > index 0000000..b68d146
> > --- /dev/null
> > +++ b/libdrm/xf86drmMode.h
> > @@ -0,0 +1,256 @@
> > +/*
> > + * \file xf86drmMode.h
> > + * Header for DRM modesetting interface.
> > + *
> > + * \author Jakob Bornecrantz <[email protected]>
> > + *
> > + * \par Acknowledgements:
> > + * Feb 2007, Dave Airlie <[email protected]>
> > + */
> > +
> > +/*
> > + * Copyright (c) <year> <copyright holders>
>
> Copyrights.
Fixed.
> > -struct drm_mm_info_arg {
> > - unsigned int mem_type;
> > - uint64_t p_size;
> > -};
> > -
>
> I think some of the drivers that are still left in the external kernel
> code will get angry about this.
I couldn't find any users of it... we've had this removal (at airlied's
request iirc) in modesetting-* for awhile now...
> > -struct drm_i915_execbuffer {
> > - uint64_t ops_list;
> > - uint32_t num_buffers;
> > - struct drm_i915_batchbuffer batch;
> > - drm_context_t context; /* for lockless use in the future */
> > - struct drm_fence_arg fence_arg;
> > -};
> > -
> > struct drm_i915_gem_init {
> > /**
> > * Beginning offset in the GTT to be managed by the DRM memory
>
> Looks like it shouldn't be part of this patchset.
Yeah, may as well omit the ttm changes altogether from this patch. Will
address the above point too.
> > +++ b/tests/modedemo/demo.c
> > +++ b/tests/modefb/demo.c
> > +++ b/tests/modehotplug/demo.c
I think these ones are busted anyway, I'll leave them out for now (Jakob can
add them back I guess if he wants)
> > +++ b/tests/modeprint/modetest.c
> (Oh, and a nice doxygen about what the test app does would be awesome)
Good point, I'll fix the copyright and add some info. And add a Makefile
while I'm at it. :)
--
Jesse Barnes, Intel Open Source Technology Center
------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you. Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
