On Wed, 7 Nov 2007, Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Robert P. J. Day wrote: > > is there something special about the drm_order() routine in > > [snip] > > > that it can't simply be replaced by an appropriate call to ilog2() > > defined in include/linux/log2.h? just curious. > > I guess the bigger question is why isn't drm_order in one of the files > in shared-core? There are identical implementations in > linux-core/drm_bufs.c and bsd-core/drm_bufs.c. We should either modify > the linux-core version to use ilog2 or move both implementations > somewhere in shared-core.
i was thinking of just adding an "order" macro/routine to log2.h, since i'm guessing there's probably other places in the code that have that same code. rday p.s. i'm thinking it might be handy to have both a roundup and rounddown order() routine, or something along those lines. -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
