Please do not reply to this email: if you want to comment on the bug, go to
the URL shown below and enter yourcomments there.
https://bugs.freedesktop.org/show_bug.cgi?id=6242
------- Additional Comments From [EMAIL PROTECTED] 2006-07-17 21:17 -------
Still untested, but this looks pretty good. You're not adding any performance
penalty because someone has to copy data into the DMA buffers for blits. You
just moved the copy from user space to kernel space and eliminated an ioctl,
which even improved performance. Neat!
It's also nice that you bundled all changes that affect the DRM interfaces in
one diff.
I have just a few little comments for improvements:
- You said it yourself, mach64_freelist_put should be moved to mach64_dma.c
- Please also bump the driver date in mach64_drv.h
- mach64FireBlitLocked should be able to handle EAGAIN or pass it back to the
caller. This is a new error condition for the blit ioctl that should be handled
more gracefully. This sort of error was handled in mach64GetBufferLocked
previously.
Another thing to keep in mind is that you don't have a solution for BSD because
you only implement the DRM_PCI_BUFFER_RO flag for linux. I'm not sure how many
people care about mach64 on BSD. I guess on BSD the flag would simply be
ignored, so PCI DMA buffers would still be mapped for writing.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
