Indan Zupancic wrote: >Hello, > >via_setInit forgot to check drm_alloc's return value, hence caused an oops. > >As I thought that via_init_context doesn't check via_setInit's return value, I >changed it a bit. The original code looks a bit confusing, so took a while to >see that it did check the return values. With my changes it finds the last >free index, if the first one is preferred then let the for loop go from >MAX_CONTEXT-1 till zero instead. Mind that the original version didn't free >sets[0] when the second via_setInit failed (not that it would ever come that >far). Feel free to ignore the second patch. > >What bothers me is that the kmalloc failed at all. The system wasn't under >heavy memory load, and all I tried running was glxinfo. The uptime wasn't >tremendous either, so memory fragmentation seems unlikely. When looking at the >kernel log there seems to be plenty of usable memory. What's also slightly >worrisome is that the rest of the logfile before the "X: page allocation >failure" is gone. Maybe something more is going on? > >All this with 2.6.18-rc1, never happened before. > >Greetings, > >Indan > >(Not subscribed, please CC me) > > Hi.
via_ds.c has disappeared from the linux drm CVS. Still around for *bsd, though. /Thomas ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
