Please do not reply to this email: if you want to comment on the bug, go to
the URL shown below and enter yourcomments there.
https://bugs.freedesktop.org/show_bug.cgi?id=6242
[EMAIL PROTECTED] changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[agp mach64] Use DMA buffers|[mach64] Use private DMA
|for mach64_dma_vertex |buffers (only)
------- Additional Comments From [EMAIL PROTECTED] 2006-04-12 10:44 -------
Start over.
The following patches implement the suggestion at comment 9.
For AGP, they reserve the AGP memory to be used for DMA buffers as READ_ONLY.
For PCI, they make drm_mmap_dma to return as soon as it is called to prevent
mapping of the DMA buffers, this will have to be handled with a flag in
drm_buf_desc_t.
mach64_dma_blit was also converted to submit a pointer to user-space and
subsituted the memcpy currently done in user-space with a copy_from_user (I
presume this is secure or can be done so easily ...). Wrt performace for PCI, I
see a ~12% speedup for some Mesa demos I tested.
Also, the patches contain some other mainly consmetic changes:
o factor out from mach64_dma_dispatch_vertex the code to reclaim an used
buffer, it is now used by mach64_dma_dispatch_blit also
o factor out from mach64_freelist_get the code to reclaim a completed buffer,
this was to improve readability for me
o move the memory reservation for the DMA ring in the PCI case to DDX,
this unifies a couple of PCI/AGP code paths for ring memory in the drm
Hope haven't managed to enter ingore lists with this bug report,
any comments are greatly appreciated,
george.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
