Ian Romanick writes:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Egbert Eich wrote:
>
> > @@ -612,8 +612,7 @@
> > _tnl_allow_pixel_fog( ctx, GL_FALSE );
> > _tnl_allow_vertex_fog( ctx, GL_TRUE );
> >
> > - mmesa->primary_offset = mmesa->mgaScreen->primary.handle;
> > -
> > + mmesa->primary_offset = drmAgpBase(sPriv->fd);
> > ctx->DriverCtx = (void *) mmesa;
> > mmesa->glCtx = ctx;
> >
> > If you look at mgaioctl.c you will find code that does arithmetic
> > with mmesa->primary_offset.
> > In my opinion the assignment:
> >
> > mmesa->primary_offset = mmesa->mgaScreen->primary.handle;
> >
> > is a bug.
>
> It is, and in more ways that this. That is why, for MGA DRM >= 3.2,
> this code is no longer used. The only use of the primary handle was to
> determine when the DMA engine had processed certain command buffers.
> This case has been replaced by an in-kernel interrupt-based wait
> mechanism. In the current code, primary_offset is always set to zero if
> DRM >= 3.2.
OK, that sounds reasonable.
Would the change I've made would still be useful for DRM < 3.2?
Cheers,
Egbert.
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
