On Fri, 2005-03-04 at 01:50 +0100, Rune Petersen wrote: > > if ( (info->ChipFamily == CHIP_FAMILY_R300) || > (info->ChipFamily == CHIP_FAMILY_R350) || > - (info->ChipFamily == CHIP_FAMILY_RV350) ) > + (info->ChipFamily == CHIP_FAMILY_RV350) || > + (info->ChipFamily == CHIP_FAMILY_R420) ) > drmInfo.func = DRM_RADEON_INIT_R300_CP; > else > if ( info->ChipFamily >= CHIP_FAMILY_R200 )
Why not just test for info->ChipFamily >= CHIP_FAMILY_R300 instead of for every R300 family explicitly? Otherwise, it looks like the R200 microcode will be used, which is certainly wrong... Incidentally, I think the R300 check in RADEONDRIScreenInit() should be moved to the top as well, or the IGP and R200 checks will preempt it? -- Earthling Michel DÃnzer | Debian (powerpc), X and DRI developer Libre software enthusiast | http://svcs.affero.net/rm.php?r=daenzer ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
