Brian Paul wrote:
I'll be checking in a fix for this soon.
I've replaced the _swrast_clip_pixelrect() functions with two new functions: _mesa_clip_readpixels() and _mesa_clip_drawpixels(). The main difference is the later one obeys the scissor rectangle.
The DRI drivers might use _mesa_clip_readpixels() but a second stage of clipping which takes place in screen space (instead of window space) is needed too. Otherwise, someone could try to read pixels outside of the framebuffer's bounds.
I'd suggest writing a screen-space clipping routine and putting it in the src/mesa/drivers/common/ or src/mesa/drivers/dri/common/ directory.
So, did you fix this yourself ?
I didn't touch any DRI code.
In any case, you might want to remove that "fprintf" near the end of the check_color function.
I guess I'd like to see the clipping issues resolved before checking in the patch.
-Brian
------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
